netdev - Re: [PATCH RFC net 0/3] ipv6: Fix potential deadlock when creating pcpu rt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150814171813.GB359689@devbig242.prn2.facebook.com>
Date:	Fri, 14 Aug 2015 10:18:13 -0700
From:	Martin KaFai Lau <kafai@...com>
To:	David Miller <davem@...emloft.net>
CC:	<netdev@...r.kernel.org>, <sgunderson@...foot.com>,
	<hannes@...essinduktion.org>, <kernel-team@...com>
Subject: Re: [PATCH RFC net 0/3] ipv6: Fix potential deadlock when creating
 pcpu rt

On Thu, Aug 13, 2015 at 05:29:09PM -0700, David Miller wrote:
> From: Martin KaFai Lau <kafai@...com>
> Date: Thu, 13 Aug 2015 00:58:00 -0700
> 
> > This patch series fixes a potential deadlock when creating a pcpu rt.
> > It happens when dst_alloc() decided to run gc. Something like this:
> > 
> > read_lock(&table->tb6_lock);
> > ip6_rt_pcpu_alloc()
> > => dst_alloc()
> > => ip6_dst_gc()
> > => write_lock(&table->tb6_lock); /* oops */
> > 
> > Patch 1 and 2 are some prep works.
> > Patch 3 is the fix.
> > 
> > Original report: https://bugzilla.kernel.org/show_bug.cgi?id=102291
> > 
> > Steinar, the patches can also be applied to 4.2-rc5 (I just tried).
> > Can you help to test them? Thanks!
> 
> This series looks fine to me.
Thanks. I will repost it with a minor change in one of the commit messages.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html