netdev - Re: [B.A.T.M.A.N.] [PATCH 03/10] batman-adv: Make DAT capability changes atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 14 Aug 2015 22:49:03 +0200
From:	Antonio Quartulli <antonio@...hcoding.com>
To:	sergei.shtylyov@...entembedded.com
Cc:	The list for a Better Approach To Mobile Ad-hoc
	 Networking <b.a.t.m.a.n@...ts.open-mesh.org>,
	davem@...emloft.net, netdev@...r.kernel.org,
	Marek Lindner <mareklindner@...mailbox.ch>
Subject: Re: [B.A.T.M.A.N.] [PATCH 03/10] batman-adv: Make DAT capability
 changes atomic



On 11/08/15 21:36, Sergei Shtylyov wrote:
>>       /* check if orig node candidate is running DAT */
>> -    if (!(candidate->capabilities & BATADV_ORIG_CAPA_HAS_DAT))
>> +    if (!(test_bit(BATADV_ORIG_CAPA_HAS_DAT, &candidate->capabilities)))
> 
>    () around the tst_bit() call not needed.

Thanks for the hint Sergei. Even if I don't remember having seen any
complaint from checkpatch.pl about this.

I'll resend the pull request with this fixed patches.

Cheers,


-- 
Antonio Quartulli


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)