netdev - Re: [PATCH net-next] rocker: hook ndo_neigh_destroy to cleanup neigh refs in driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150813.170702.2090658035067871522.davem@davemloft.net>
Date:	Thu, 13 Aug 2015 17:07:02 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sfeldma@...il.com
Cc:	netdev@...r.kernel.org, jiri@...nulli.us
Subject: Re: [PATCH net-next] rocker: hook ndo_neigh_destroy to cleanup
 neigh refs in driver

From: sfeldma@...il.com
Date: Wed, 12 Aug 2015 18:45:25 -0700

> From: Scott Feldman <sfeldma@...il.com>
> 
> Rocker driver tracks arp_tbl neighs to resolve IPv4 route nexthops.  The
> driver uses NETEVENT_NEIGH_UPDATE for neigh adds and updates, but there is
> no event when the neigh is removed from the device (such as when the device
> goes admin down).  This patches hooks ndo_neigh_destroy so the driver can
> know when a neigh is removed from the device.  In response, the driver will
> purge the neigh entry from its internal tbl.
> 
> I didn't find an in-tree users of ndo_neigh_destroy, so I'm not sure if
> this ndo is vestigial or if there are out-of-tree users.  In any case, it
> does what I need here.  An alternative design would be to generate
> NETEVENT_NEIGH_UPDATE event when neigh is being destroyed, setting state to
> NUD_NONE so driver knows neigh entry is dead.
> 
> Signed-off-by: Scott Feldman <sfeldma@...il.com>

Also applied.

->ndo_neigh_destroy() is there simply for completeness.  If anyone
needed to manage neigh's they likely would have private software state
assosciated with entries they would need to release when the neigh
object is going away.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html