netdev - Re: [PATCH] net: rtnetlink: be more strict when setting MAC address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150817.140933.1342685440755543932.davem@davemloft.net>
Date:	Mon, 17 Aug 2015 14:09:33 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	phil@....cc
Cc:	netdev@...r.kernel.org, tgraf@...g.ch
Subject: Re: [PATCH] net: rtnetlink: be more strict when setting MAC address

From: Phil Sutter <phil@....cc>
Date: Mon, 17 Aug 2015 23:06:47 +0200

> Upon evaluation of IFLA_ADDRESS and IFLA_BROADCAST messages, make sure
> the passed argument length matches dev->addr_len exactly.
> 
> This fixes dubious behaviour of 'ip link set eth0 addr <MAC>' where
> '<MAC>' is too long, e.g. '00:11:22:33:44:55:66:77'. Called like this,
> 'ip' would return successfully and the kernel sets eth0's MAC address to
> the leading six octets of the passed argument.
> 
> Signed-off-by: Phil Sutter <phil@....cc>

I don't think this behavior is very "dubious" and making the check more
strict risks breaking things that have worked for a very long time.

I'm not applying this, sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html