[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <55D26194.5060702@arm.com>
Date: Mon, 17 Aug 2015 17:35:00 -0500
From: Jeremy Linton <jeremy.linton@....com>
To: Guenter Roeck <linux@...ck-us.net>,
Steve Glendinning <steve.glendinning@...well.net>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is
configured or used
On 08/17/2015 05:14 PM, Guenter Roeck wrote:
> One nitpick I noticed after sending my patch: dev can never be NULL in
> smsc911x_probe_config(), so it does not really make sense to check if it is NULL.
No, it doesn't... it should really be something like
if (dev_fwnode(dev))
But dev_fwnode is static inline in property.c, and i'm pretty sure that
still isn't 100% correct.The best plan might just be to remove the
check, and abort on failure to find the phy property per your patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists