| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAAVeFuK00Gp5mbXAMYp0dM0AmHjeY76jS9CYNJqRS720F1zbDA@mail.gmail.com> Date: Mon, 17 Aug 2015 16:41:37 +0900 From: Alexandre Courbot <gnurou@...il.com> To: Alban Bedel <albeu@...e.fr> Cc: linux-mips <linux-mips@...ux-mips.org>, Ralf Baechle <ralf@...ux-mips.org>, Hauke Mehrtens <hauke@...ke-m.de>, Rafał Miłecki <zajec5@...il.com>, Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>, Tejun Heo <tj@...nel.org>, Linus Walleij <linus.walleij@...aro.org>, Dmitry Torokhov <dmitry.torokhov@...il.com>, Florian Fainelli <florian@...nwrt.org>, Manuel Lauss <manuel.lauss@...il.com>, Joe Perches <joe@...ches.com>, Daniel Walter <dwalter@...gle.com>, Sergey Ryazanov <ryazanov.s.a@...il.com>, Huacai Chen <chenhc@...ote.com>, James Hartley <james.hartley@...tec.com>, Andrew Bresticker <abrestic@...omium.org>, Paul Burton <paul.burton@...tec.com>, Lars-Peter Clausen <lars@...afoo.de>, Brian Norris <computersforpeace@...il.com>, Varka Bhadram <varkabhadram@...il.com>, Wolfram Sang <wsa@...-dreams.de>, Randy Dunlap <rdunlap@...radead.org>, Simon Horman <horms+renesas@...ge.net.au>, Bjorn Helgaas <bhelgaas@...gle.com>, Masanari Iida <standby24x7@...il.com>, Mauro Carvalho Chehab <m.chehab@...sung.com>, Michael Buesch <m@...s.ch>, abdoulaye berthe <berthe.ab@...il.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-ide@...r.kernel.org, "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>, Linux Input <linux-input@...r.kernel.org>, netdev <netdev@...r.kernel.org> Subject: Re: [PATCH v3] MIPS: Remove all the uses of custom gpio.h On Tue, Aug 4, 2015 at 5:50 PM, Alban Bedel <albeu@...e.fr> wrote: > Currently CONFIG_ARCH_HAVE_CUSTOM_GPIO_H is defined for all MIPS > machines, and each machine type provides its own gpio.h. However > only a handful really implement the GPIO API, most just forward > everythings to gpiolib. > > The Alchemy machine is notable as it provides a system to allow > implementing the GPIO API at the board level. But it is not used by > any board currently supported, so it can also be removed. > > For most machine types we can just remove the custom gpio.h, as well > as the custom wrappers if some exists. Some of the code found in > the wrappers must be moved to the respective GPIO driver. > > A few more fixes are need in some drivers as they rely on linux/gpio.h > to provides some machine specific definitions, or used asm/gpio.h > instead of linux/gpio.h for the gpio API. > > Signed-off-by: Alban Bedel <albeu@...e.fr> > --- > > This patch is based on my previous serie: > "MIPS: ath79: Move the GPIO driver to drivers/gpio". > > It supercede my previous patch named: > "MIPS: Remove most of the custom gpio.h" > > Changelog: > v3: * Add the missing includes to fix the build on jz4740 machines > v2: * Don't remove AR7_GPIO_MAX and TITAN_GPIO_MAX, that's for another > patch > v1: * Fixed gpio_to_irq on jz4740 and rb532 > * Cleaned up alchemy as well > * Removed asm/gpio.h > > For testing I tried to build all mips defconfig, however my toolchain > couldn't handle a few configs: ip28 malta_qemu_32r6 maltasmvp_eva > sead3micro. If somebody can test these that would be more than welcome. > > Now a few stats about the state of CONFIG_ARCH_HAVE_CUSTOM_GPIO_H > after appling this patch. Of the 31 supportd arch, 15 still have > asm/gpio.h, of these 9 are just a "#warning Include linux/gpio.h > instead of asm/gpio.h". So we have 6 arch left: arm, avr32, blackfin, > m68k, sh and unicore32. But only m68k and unicore32 really provides > custom wrappers, all the others only forward to gpiolib. > > On the drivers side we only have 13 occurences of '#include > <asm/gpio.h>' left, mostly in drivers used on ARM SoC. > > So the work left to phase out the legacy GPIO is really not that much > anymore. > > Alban > --- > arch/mips/Kconfig | 1 - > arch/mips/alchemy/Kconfig | 7 -- > arch/mips/alchemy/board-gpr.c | 1 + > arch/mips/alchemy/board-mtx1.c | 1 + > arch/mips/alchemy/common/Makefile | 7 +- > arch/mips/alchemy/devboards/db1000.c | 1 + > arch/mips/alchemy/devboards/db1300.c | 1 + > arch/mips/alchemy/devboards/db1550.c | 1 + > arch/mips/alchemy/devboards/pm.c | 2 +- > arch/mips/ar7/gpio.c | 5 +- > arch/mips/ar7/platform.c | 1 - > arch/mips/ar7/setup.c | 1 - > arch/mips/include/asm/gpio.h | 6 - > arch/mips/include/asm/mach-ar7/ar7.h | 4 + > arch/mips/include/asm/mach-ar7/gpio.h | 41 ------- > arch/mips/include/asm/mach-ath25/gpio.h | 16 --- > arch/mips/include/asm/mach-ath79/gpio.h | 26 ----- > arch/mips/include/asm/mach-au1x00/gpio-au1000.h | 148 ++---------------------- > arch/mips/include/asm/mach-au1x00/gpio.h | 86 -------------- > arch/mips/include/asm/mach-bcm47xx/gpio.h | 17 --- > arch/mips/include/asm/mach-bcm63xx/gpio.h | 15 --- > arch/mips/include/asm/mach-cavium-octeon/gpio.h | 21 ---- > arch/mips/include/asm/mach-generic/gpio.h | 21 ---- > arch/mips/include/asm/mach-jz4740/gpio.h | 2 - > arch/mips/include/asm/mach-lantiq/gpio.h | 13 --- > arch/mips/include/asm/mach-loongson64/gpio.h | 36 ------ > arch/mips/include/asm/mach-pistachio/gpio.h | 21 ---- > arch/mips/include/asm/mach-rc32434/gpio.h | 12 -- > arch/mips/jz4740/board-qi_lb60.c | 1 + > arch/mips/jz4740/gpio.c | 21 ++-- > arch/mips/pci/pci-lantiq.c | 1 - > arch/mips/rb532/devices.c | 1 + > arch/mips/rb532/gpio.c | 6 + > arch/mips/txx9/generic/setup.c | 16 --- > drivers/ata/pata_rb532_cf.c | 3 +- > drivers/gpio/gpio-ath79.c | 32 ----- > drivers/input/misc/rb532_button.c | 1 + > drivers/net/ethernet/ti/cpmac.c | 2 + > 38 files changed, 47 insertions(+), 551 deletions(-) Acked-by: Alexandre Courbot <acourbot@...dia.com> Great cleanup job! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists