netdev - Re: [PATCH net-next]:r8169: Add and modify some parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55D1E571.8080200@redhat.com>
Date:	Mon, 17 Aug 2015 15:45:21 +0200
From:	Ivan Vecera <ivecera@...hat.com>
To:	Corcodel Marian <corcodel.marian@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next]:r8169: Add and modify some parameters

On 17.8.2015 12:26, Corcodel Marian wrote:
> Set InterFrame Gap time as largest posible for comp.   Add
>   InterFrameGap2 bit set on start.

Why?

>
> Signed-off-by: Corcodel Marian <corcodel.marian@...il.com>
>
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index eb2d2a4..ea0f327 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -86,7 +86,8 @@ static const int multicast_filter_limit = 32;
>
>   #define MAX_READ_REQUEST_SHIFT	12
>   #define TX_DMA_BURST	7	/* Maximum PCI burst, '7' is unlimited */
> -#define InterFrameGap	0x03	/* 3 means InterFrameGap = the shortest one */
> +#define InterFrameGap	0x02	/* 2 means InterFrameGap = the largest one */
> +#define InterFrameGap2	0x80000
>
>   #define R8169_REGS_SIZE		256
>   #define R8169_NAPI_WEIGHT	64
> @@ -5180,7 +5181,7 @@ static void rtl_set_rx_tx_config_registers(struct rtl8169_private *tp)
>
>   	/* Set DMA burst size and Interframe Gap Time */
>   	RTL_W32(TxConfig, (TX_DMA_BURST << TxDMAShift) |
> -		(InterFrameGap << TxInterFrameGapShift));
> +		(InterFrameGap << TxInterFrameGapShift) | InterFrameGap2);
>   }
>
>   static void rtl_hw_start(struct net_device *dev)
> @@ -7470,15 +7471,22 @@ static int rtl8169_poll(struct napi_struct *napi, int budget)
>   	u16 enable_mask = RTL_EVENT_NAPI | tp->event_slow;
>   	int work_done= 0;
>   	u16 status;
> +        int tx_force = 1;
>
>   	status = rtl_get_events(tp);
>   	rtl_ack_events(tp, status & ~tp->event_slow);
> -
> +       if (netif_running(dev)) {
>   	if (status & RTL_EVENT_NAPI_RX)
>   		work_done = rtl_rx(dev, tp, (u32) budget);
> +
>
>   	if (status & RTL_EVENT_NAPI_TX)
>   		rtl_tx(dev, tp);
> +         else if (tx_force == 1) {
> +                mdelay(10);
> +                rtl_tx(dev, tp);
> +         }
> +        }
>
>   	if (status & tp->event_slow) {
>   		enable_mask &= ~tp->event_slow;
>
Why this piece of code??? This was already rejected.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html