netdev - Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150817.140637.1398365618268358269.davem@davemloft.net>
Date:	Mon, 17 Aug 2015 14:06:37 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	linux@...ck-us.net
Cc:	steve.glendinning@...well.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, jeremy.linton@....com
Subject: Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF
 is configured or used

From: Guenter Roeck <linux@...ck-us.net>
Date: Mon, 17 Aug 2015 13:45:36 -0700

> Commit 0b50dc4fc971 ("Convert smsc911x to use ACPI as well as DT") makes
> the call to smsc911x_probe_config() unconditional, and no longer fails if
> there is no device node. device_get_phy_mode() is called unconditionally,
> and if there is no phy node configured returns an error code. This error
> code is assigned to phy_interface, and interpreted elsewhere in the code
> as valid phy mode. This in turn causes qemu to crash when running a
> variant of realview_pb_defconfig.
> 
> 	qemu: hardware error: lan9118_read: Bad reg 0x86
> 
> Fixes: 0b50dc4fc971 ("Convert smsc911x to use ACPI as well as DT")
> Cc: Jeremy Linton <jeremy.linton@....com>
> Cc Graeme Gregory <graeme.gregory@...aro.org>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html