netdev - Re: [PATCH net-next v2] vrf: vrf_master_ifindex_rcu is not always called with rcu read lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 18 Aug 2015 23:24:27 +0300
From:	Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:	David Ahern <dsa@...ulusnetworks.com>
Cc:	netdev@...r.kernel.org, shm@...ulusnetworks.com,
	davem@...emloft.net
Subject: Re: [PATCH net-next v2] vrf: vrf_master_ifindex_rcu is not always called with rcu read lock


> On Aug 18, 2015, at 11:10 PM, David Ahern <dsa@...ulusnetworks.com> wrote:
> 
> On 8/18/15 12:15 PM, Nikolay Aleksandrov wrote:
>> diff --git a/include/net/vrf.h b/include/net/vrf.h
>> index 3bb4af462ed6..b039850a94a3 100644
>> --- a/include/net/vrf.h
>> +++ b/include/net/vrf.h
>> @@ -34,7 +34,6 @@ struct net_vrf {
>> 
>> 
>>  #if IS_ENABLED(CONFIG_NET_VRF)
>> -/* called with rcu_read_lock() */
>>  static inline int vrf_master_ifindex_rcu(const struct net_device *dev)
>>  {
>>  	struct net_vrf_dev *vrf_ptr;
> 
> That comment is true for this version.
> 
> David
> 

It is, but as we established the name implies the same. Anyway I’ll post a v3 and
keep it.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html