netdev - Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150818.134720.1520233036019988872.davem@davemloft.net>
Date:	Tue, 18 Aug 2015 13:47:20 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sfeldma@...il.com
Cc:	netdev@...r.kernel.org, andrew@...n.ch, jiri@...nulli.us
Subject: Re: [PATCH net-next v3] rocker: add debugfs support to dump
 internal tables

From: Scott Feldman <sfeldma@...il.com>
Date: Tue, 18 Aug 2015 13:37:56 -0700

> On Tue, Aug 18, 2015 at 11:19 AM, Andrew Lunn <andrew@...n.ch> wrote:
>> On Tue, Aug 18, 2015 at 10:18:51AM -0700, Scott Feldman wrote:
>>> On Tue, Aug 18, 2015 at 7:01 AM, Andrew Lunn <andrew@...n.ch> wrote:
>>> > On Mon, Aug 17, 2015 at 03:36:17PM -0700, sfeldma@...il.com wrote:
>>> >> From: Scott Feldman <sfeldma@...il.com>
>>> >>
>>> >> > tree /sys/kernel/debug/rocker
>>> >> /sys/kernel/debug/rocker
>>> >> ????????? 5254001235010000
>>> >>     ????????? fdb_tbl
>>> >>     ????????? internal_vlan_tbl
>>> >>     ????????? neigh_tbl
>>> >>     ????????? of_dpa_flow_tbl
>>> >>     ????????? of_dpa_group_tbl
>>> >>
>>> >> 1 directory, 5 files
>>> >>
>>> >> > cat /sys/kernel/debug/rocker/5254001235010000/internal_vlan_tbl
>>> >> ifindex 5 ref_count 1 vlan 3843
>>> >> ifindex 7 ref_count 2 vlan 3840
>>> >> ifindex 4 ref_count 1 vlan 3842
>>> >>
>>> >> > cat /sys/kernel/debug/rocker/5254001235010000/fdb_tbl
>>> >> learned 1 pport 1 addr 00:02:00:00:02:00 vlan 3840
>>> >> learned 1 pport 2 addr 00:02:00:00:03:00 vlan 3840
>>> >>
>>> >> > cat /sys/kernel/debug/rocker/5254001235010000/neigh_tbl
>>> >> 11.0.0.9 dev sw1p2 ref_count 3 index 1 dst 00:02:00:00:01:00 ttl_check 1
>>> >> 11.0.0.1 dev sw1p1 ref_count 3 index 0 dst 00:02:00:00:00:00 ttl_check 1
>>> >
>>> > Hi Scott
>>> >
>>> > David is not so keen no debugfs stuff. He already NACKed adding more
>>> > than what is currently in DSA:
>>> >
>>> > https://lkml.org/lkml/2015/7/11/8
>>>
>>> That patch added writable debugfs files, which I can see might be used
>>> as a back-door to program hardware.  That does seem bad.
>>
>> I fully agreed with respect to write. But if you read the whole
>> message, David is also not happy with read only.
>>
>> I think before you spend too much more time on this, you need some
>> indication from David if he is going to merge it or not.
> 
> David, please give us guidance on debugfs in drivers/net.  Is there
> some criteria we can define to know when it's OK to use debugfs?

The less you use it the better, seriously.

I see some drivers where the foo_debugfs.c file is larger than the rest
of the driver.  Once people start using it, it's like crack, and they
dump every single debugging widget they found useful at some point into
there.

This is not what we want.  Most things I see in debugfs support was
probably useful for debugging one particular bug but then it was never
really useful again in the future.  Those kinds of things can be done
locally in someone's tree.

I often see various kinds of "statistics" ending up in these things,
or register dumps, both of which are 'ethtool' or similar material.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html