netdev - Re: [PATCH net-next v2 5/9] geneve: Add support to collect tunnel metadata.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150818.141232.155283851688115226.davem@davemloft.net>
Date:	Tue, 18 Aug 2015 14:12:32 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	pshelar@...ira.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 5/9] geneve: Add support to collect tunnel
 metadata.

From: Pravin B Shelar <pshelar@...ira.com>
Date: Mon, 17 Aug 2015 14:11:41 -0700

> +	if (tun_dst)
> +		skb_dst_set(skb, (struct dst_entry *)tun_dst);
> +

Please don't cast things like this, it is completely unnecessary:

	skb_dst_set(skb, &tun_dst->dst);
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html