netdev - Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150818075249.GC2200@nanopsycho.orion>
Date:	Tue, 18 Aug 2015 09:52:49 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	Scott Feldman <sfeldma@...il.com>
Cc:	Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v3] rocker: add debugfs support to dump internal
 tables

Tue, Aug 18, 2015 at 09:21:15AM CEST, sfeldma@...il.com wrote:
>On Mon, Aug 17, 2015 at 11:48 PM, Jiri Pirko <jiri@...nulli.us> wrote:
>> Tue, Aug 18, 2015 at 08:14:48AM CEST, sfeldma@...il.com wrote:
>>>On Mon, Aug 17, 2015 at 10:55 PM, Jiri Pirko <jiri@...nulli.us> wrote:
>>>> Tue, Aug 18, 2015 at 12:36:17AM CEST, sfeldma@...il.com wrote:
>>>>>From: Scott Feldman <sfeldma@...il.com>
>>>>
>>>> <snip>
>>>>
>>>>>+      rocker->dbg_dir = debugfs_create_dir(dbg_dir_name, rocker_dbg_root);
>>>>>+      if (!rocker->dbg_dir)
>>>>
>>>> You still check the retval here and
>>>
>>>It's OK.  See include/linux/debugfs.h when CONFIG_DEBUG_FS=n.
>>>debugfs_create_dir() returns ERR_PTR(-ENODEV), which is !NULL.
>>
>> Does not make sense to check it for NULL then. It is never NULL...
>
>It can be NULL when CONFIG_DEBUG_FS=y.

You are right, this inconsistency looks odd to me though.

Anyway,

Acked-by: Jiri Pirko <jiri@...nulli.us>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html