netdev - Re: [PATCH 20/21] net: warn if drivers set tx_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1439909248.6443.19.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Tue, 18 Aug 2015 07:47:28 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Phil Sutter <phil@....cc>
Cc:	netdev@...r.kernel.org, brouer@...hat.com, davem@...emloft.net
Subject: Re: [PATCH 20/21] net: warn if drivers set tx_queue_len = 0

On Tue, 2015-08-18 at 10:30 +0200, Phil Sutter wrote:
> Due to the introduction of IFF_NO_QUEUE, there is a better way for
> drivers to indicate that no qdisc should be attached by default. Though,
> the old convention can't be dropped since ignoring that setting would
> break drivers still using it. Instead, add a warning so out-of-tree
> driver maintainers get a chance to adjust their code before we finally
> get rid of any special handling of tx_queue_len == 0.

How an admin can remove qdisc on a regular ethernet device with this
schem ?

I was doing :

tc qdisc replace dev eth0 root pfifo
ifconfig eth0 txqueuelen 0
tc qdisc del dev eth0 root


I see nothing in your patches to avoid the DEPRECATED warning.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html