netdev - Re: [PATCH v2 net-next 01/13] ip_tunnels: remove custom alignment and packing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150819162009.GA3635@pox.localdomain>
Date:	Wed, 19 Aug 2015 18:20:09 +0200
From:	Thomas Graf <tgraf@...g.ch>
To:	Jiri Benc <jbenc@...hat.com>
Cc:	netdev@...r.kernel.org, dev@...nvswitch.org
Subject: Re: [PATCH v2 net-next 01/13] ip_tunnels: remove custom alignment
 and packing

On 08/19/15 at 12:09pm, Jiri Benc wrote:
> The custom alignment of struct ip_tunnel_key is unnecessary. In struct
> sw_flow_key, it starts at offset 256, in struct ip_tunnel_info it's the
> first field.
> 
> The structure is also packed even without the __packed keyword.
> 
> Signed-off-by: Jiri Benc <jbenc@...hat.com>

I came to the same conclusion but didn't want to change it in the original
series.

Acked-by: Thomas Graf <tgraf@...g.ch>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html