| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1440004777.6610.23.camel@edumazet-glaptop2.roam.corp.google.com> Date: Wed, 19 Aug 2015 10:19:37 -0700 From: Eric Dumazet <eric.dumazet@...il.com> To: "Grumbach, Emmanuel" <emmanuel.grumbach@...el.com> Cc: "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>, "ido@...ery.com" <ido@...ery.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: Re: [RFC v2 0/3] add TSO / A-MSDU TX for iwlwifi On Wed, 2015-08-19 at 17:00 +0000, Grumbach, Emmanuel wrote: > > On 08/19/2015 07:08 PM, Eric Dumazet wrote: > > On Wed, 2015-08-19 at 15:07 +0000, Grumbach, Emmanuel wrote: > > > >> I'll look at it. > >> I was almost starting to implement that but then I thought with another > >> (good?) reason to use LSO. LSO gives me the guarantee that the packet is > >> directed to one peer, which might not be the case with xmit_more since > >> we have one Qdisc for several clients in case we are in AP mode. > >> Building an A-MSDU for several clients is not possible, at least not for > >> several client in the L2 (different MAC addresses). > >> LSO avoids this problem completely. > > > > Then, simply calling skb_gso_segment() from the driver might be enough, > > and less work for you. > > > > This would even support TSO on IPv6 > > > > Well... I did take care of IPv6. net/core/tso.c does not yet handle IPv6 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists