netdev - Re: [RFC v2 0/3] add TSO / A-MSDU TX for iwlwifi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 19 Aug 2015 18:09:16 +0000
From:	"Grumbach, Emmanuel" <emmanuel.grumbach@...el.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"ido@...ery.com" <ido@...ery.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [RFC v2 0/3] add TSO / A-MSDU TX for iwlwifi



On 08/19/2015 09:02 PM, Eric Dumazet wrote:
> On Wed, 2015-08-19 at 17:56 +0000, Grumbach, Emmanuel wrote:
>>
> 
>> So I feel that making net/core/tso.c more complicated just because of
>> our craziness seems an overkill to me.
>> I'll try a bit harder to see how I can use net/core/tso.c, but I have to
>> say I am pessimistic.
> 
> net/core/tso.c is WIP, feel free to expand it to make it more generic
> and meet your needs.

Yeah - trying to see what can be done.

>
> The point is : we want a core infrastructure, not something that each
> individual driver implements in ~500 lines of code :(
> 
> 

I totally understand that :) I just claim to be unique in a way that
"each individual driver" is ... only me :)

I guess that if we would build the DMA descriptors directly from the
skb_gso (the skb coming from the stack), that's be easier. Our HW
abstraction layer wants an skb and I need to pass several skbs (because
skb->len is very likely not to fit in one single 802.11 packet even if
it is an A-MSDU).
So, trying to use net/core/tso.c basically means, to open the arch of
our driver... Not impossible, but quite a bit of work.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html