[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAEP_g=8Wq1jmrWT6a9K55JJsMNxw+Rw0h2zDby_HR6b12LJ5+w@mail.gmail.com>
Date: Wed, 19 Aug 2015 11:37:38 -0700
From: Jesse Gross <jesse@...ira.com>
To: Pravin Shelar <pshelar@...ira.com>
Cc: netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2 7/9] geneve: Consolidate Geneve functionality
in single module.
On Wed, Aug 19, 2015 at 11:29 AM, Pravin Shelar <pshelar@...ira.com> wrote:
> On Wed, Aug 19, 2015 at 11:18 AM, Jesse Gross <jesse@...ira.com> wrote:
>> My guess is that if the issue from the earlier patch about overlapping
>> collect_md tunnels is fixed then that might allow us to simplify
>> things a little further, since for those tunnels we can assume there
>> is a 1:1 mapping between collect_md tunnels and sockets.
>
> I dont see how it would be different. Can you elaborate on this ?
Mostly just conceptually simpler. Right now it looks like we are doing
some kind of refcounting between devices and tunnels in
geneve_open/stop (I know it's not really but it appears like that in
some ways.) We could just directly assign collect_md in geneve_open()
and do nothing at all in geneve_stop().
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists