netdev - Re: [PATCH 20/21] net: warn if drivers set tx_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150819202104.GB12537@orbit.nwl.cc>
Date:	Wed, 19 Aug 2015 22:21:04 +0200
From:	Phil Sutter <phil@....cc>
To:	Eric Dumazet <eric.dumazet@...il.com>, netdev@...r.kernel.org,
	brouer@...hat.com, davem@...emloft.net
Subject: Re: [PATCH 20/21] net: warn if drivers set tx_queue_len = 0

On Wed, Aug 19, 2015 at 08:39:24PM +0200, Phil Sutter wrote:
[...]
> I'll start implementing the above immediately, but would appreciate to
> hear your comments on it meanwhile. I wonder especially what makes the
> difference between pfifo and pfifo_fast and why the latter can't be
> selected explicitly by a user yet. Are there any good reasons for it
> aside from it being the "default" and therefore selecting it can be done
> by having tx_queue_len > 0 and removing the root qdisc?

Please ignore most of my questions regarding pfifo_fast here. I based my
assumptions upon 'tc' utility of RHEL7, which is buggy in that it does
not allow to add qdiscs which do not support extra options. Using
mainline tc, pfifo_fast can be attached just like any other qdisc.

Sorry for the noise,

Phil
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html