netdev - Re: [PATCH net-next] r8169:Set RxConfig on same func. with TxConfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGg4U=FDptTDEuw2r266o9KWun9UaEEZUt9XRnxRgnxv=foXhg@mail.gmail.com>
Date:	Wed, 19 Aug 2015 08:39:03 +0300
From:	Marian Corcodel <corcodel.marian@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] r8169:Set RxConfig on same func. with TxConfig

It s not mandatory to accept
these patches, if you wish
to apply good if you not ,not problem.

2015-08-18 23:04 GMT+03:00, Eric Dumazet <eric.dumazet@...il.com>:
> On Tue, 2015-08-18 at 22:10 +0300, Corcodel Marian wrote:
>>  Add set DMA burst size and  Rx FIFO threshold on RxConfig
>>   register to function rtl_set_rx_tx_config_register.
>>
>>
>> Signed-off-by: Corcodel Marian <corcodel.marian@...il.com>
>>
>> diff --git a/drivers/net/ethernet/realtek/r8169.c
>> b/drivers/net/ethernet/realtek/r8169.c
>> index 6d16de3..c3c908c 100644
>> --- a/drivers/net/ethernet/realtek/r8169.c
>> +++ b/drivers/net/ethernet/realtek/r8169.c
>> @@ -5183,6 +5183,7 @@ static void rtl_set_rx_tx_config_registers(struct
>> rtl8169_private *tp)
>>  	/* Set DMA burst size and Interframe Gap Time */
>>  	RTL_W32(TxConfig, (TX_DMA_BURST << TxDMAShift) |
>>                  (InterFrameGap << TxInterFrameGapShift) |
>> InterFrameGap2);
>> +	RTL_W32(RxConfig, RX_FIFO_THRESHOLD | RX_DMA_BURST);
>>  }
>>
>>  static void rtl_hw_start(struct net_device *dev)
>
> This does not even compile. This is insane.
>
>
>
>   CC [M]  drivers/net/ethernet/realtek/r8169.o
> drivers/net/ethernet/realtek/r8169.c: In function
> ‘rtl_set_rx_tx_config_registers’:
> drivers/net/ethernet/realtek/r8169.c:5186:20: error: ‘RX_FIFO_THRESHOLD’
> undeclared (first use in this function)
>   RTL_W32(RxConfig, RX_FIFO_THRESHOLD | RX_DMA_BURST);
>                     ^
> drivers/net/ethernet/realtek/r8169.c:104:38: note: in definition of
> macro ‘RTL_W32’
>  #define RTL_W32(reg, val32) writel ((val32), ioaddr + (reg))
>                                       ^
> drivers/net/ethernet/realtek/r8169.c:5186:20: note: each undeclared
> identifier is reported only once for each function it appears in
>   RTL_W32(RxConfig, RX_FIFO_THRESHOLD | RX_DMA_BURST);
>                     ^
> drivers/net/ethernet/realtek/r8169.c:104:38: note: in definition of
> macro ‘RTL_W32’
>  #define RTL_W32(reg, val32) writel ((val32), ioaddr + (reg))
>                                       ^
> make[1]: *** [drivers/net/ethernet/realtek/r8169.o] Error 1
> make: *** [drivers/net/ethernet/realtek/r8169.o] Error 2
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html