[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150819094003.65ff7185@griffin>
Date: Wed, 19 Aug 2015 09:40:03 +0200
From: Jiri Benc <jbenc@...hat.com>
To: Ying Xue <ying.xue@...driver.com>
Cc: <netdev@...r.kernel.org>, <davem@...emloft.net>,
<fengguang.wu@...el.com>, <kbuild-all@...org>
Subject: Re: [PATCH] lwtunnel: Fix the sparse warnings in fib_encap_match
On Wed, 19 Aug 2015 15:33:29 +0800, Ying Xue wrote:
> When CONFIG_LWTUNNEL config is not enabled, the lwtstate_free() is not
> declared in lwtunnel.h at all. However, even in this case, the function
> is still referenced in fib_semantics.c so that there appears the
> following sparse warnings:
>
> net/ipv4/fib_semantics.c:553:17: error: undefined identifier 'lwtstate_free'
> CC net/ipv4/fib_semantics.o
> net/ipv4/fib_semantics.c: In function ‘fib_encap_match’:
> net/ipv4/fib_semantics.c:553:3: error: implicit declaration of function ‘lwtstate_free’ [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
> make[1]: *** [net/ipv4/fib_semantics.o] Error 1
> make: *** [net/ipv4/fib_semantics.o] Error 2
>
> To eliminate the error, we define an empty function for lwtstate_free()
> in lwtunnel.h when CONFIG_LWTUNNEL is disabled.
>
> Fixes: df383e6240ef ("lwtunnel: fix memory leak")
> Cc: Jiri Benc <jbenc@...hat.com>
> Reported-by: kbuild test robot <fengguang.wu@...el.com>
> Signed-off-by: Ying Xue <ying.xue@...driver.com>
Acked-by: Jiri Benc <jbenc@...hat.com>
Thanks, you beat me to it.
This is for net-next.
Jiri
--
Jiri Benc
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists