netdev - Re: [PATCH net-next 1/2] lwt: Add cfg argumnt to build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150819125211.7d2afcaa@griffin>
Date:	Wed, 19 Aug 2015 12:52:11 +0200
From:	Jiri Benc <jbenc@...hat.com>
To:	Tom Herbert <tom@...bertland.com>
Cc:	<davem@...emloft.net>, <roopa@...ulusnetworks.com>,
	<netdev@...r.kernel.org>, <kernel-team@...com>
Subject: Re: [PATCH net-next 1/2] lwt: Add cfg argumnt to build_state

On Tue, 18 Aug 2015 20:21:10 -0700, Tom Herbert wrote:
> diff --git a/include/net/lwtunnel.h b/include/net/lwtunnel.h
> index e25b60e..9bf7e6a 100644
> --- a/include/net/lwtunnel.h
> +++ b/include/net/lwtunnel.h
> @@ -26,7 +26,8 @@ struct lwtunnel_state {
>  
>  struct lwtunnel_encap_ops {
>  	int (*build_state)(struct net_device *dev, struct nlattr *encap,
> -			   struct lwtunnel_state **ts);
> +			   struct lwtunnel_state **ts,
> +			   unsigned int family, const void *cfg);

Could you please keep the output parameter as the last one?

(It might be better if build_state returned the newly allocated struct
instead and used pointer encoded errors but that's for a different
patch.)

 Jiri

-- 
Jiri Benc
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html