netdev - Re: [PATCH] veth: replace iflink by a dedicated symlink in sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150820135307.3ce12f69@griffin>
Date:	Thu, 20 Aug 2015 13:53:07 +0200
From:	Jiri Benc <jbenc@...hat.com>
To:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc:	Vincent Bernat <vincent@...nat.im>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] veth: replace iflink by a dedicated symlink in sysfs

On Wed, 19 Aug 2015 18:33:14 +0200, Nicolas Dichtel wrote:
> Probably better to introduce veth netlink attribute then, something like
> IFLA_VETH_PEER and keeps IFLA_LINK_NETNSID.

I'd prefer IFLA_PEER. More generic attribute will be helpful should we
introduce an interface similar to veth in the future.

Also, I'd not combine IFLA_LINK_NETNSID with IFLA_PEER. There might
very well be an interface in the future that will need both IFLA_LINK and
IFLA_PEER and this would just create a confusion. It may be unlikely
but the attributes are cheap and it doesn't make sense to design uAPI
in a way that might bring problems in the future.

> I also don't know what is the best way to handle this. veth advertises
> its peer via IFLA_LINK since 4.1, so it's too late to change it for this
> release.

Apparently we need to pick our poison. Either way, we break something.

 Jiri

-- 
Jiri Benc
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html