netdev - Re: [PATCH, net-next] r8169: Disable some bits on pcie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1440078243.6610.45.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 20 Aug 2015 06:44:03 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Corcodel Marian <corcodel.marian@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH, net-next] r8169: Disable some bits on pcie

On Thu, 2015-08-20 at 13:12 +0300, Corcodel Marian wrote:
> Disable legacy interrupt on pci express interface use msi 
>  disable some bits from pci express interface wich is not   need on this nic.
> 
> 
> Signed-off-by: Corcodel Marian <corcodel.marian@...il.com>
> 
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 6d16de3..b1fb54f 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -8164,6 +8164,13 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>  	if (!pci_is_pcie(pdev))
>  		netif_info(tp, probe, dev, "not PCI Express\n");
>  
> +	if (pci_is_pcie(pdev))
> +		pci_write_config_word(pdev, PCI_COMMAND, ~(PCI_COMMAND_FAST_BACK | PCI_COMMAND_WAIT |
> +					PCI_COMMAND_VGA_PALETTE | PCI_COMMAND_INVALIDATE | PCI_COMMAND_SPECIAL));
> +
> +	if (pci_is_pcie(pdev))
> +		pci_intx(pdev, 0);
> +
>  	/* Identify chip attached to board */
>  	rtl8169_get_mac_version(tp, dev, cfg->default_ver);
>  

Why is it needed ?

PCI_COMMAND_VGA_PALETTE is never used in a networking driver, why should
we eventually take care ?

What exact problem are you solving ?

We wont accept a patch without a clear description, given all the crap
you have sent.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html