netdev - Re: [PATCH net-next 2/3] qeth: Convert use of __constant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK-LDbKJwjgOSgva-4yUay-wOXqAtS=tn-soE9H5xvMQMV56wA@mail.gmail.com>
Date:	Fri, 21 Aug 2015 00:28:59 +0530
From:	Vaishali Thakkar <vthakkar1994@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	Ursula Braun <ubraun@...ux.vnet.ibm.com>, David.Laight@...lab.com,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	netdev@...r.kernel.org, linux-s390@...r.kernel.org,
	Ursula Braun <ursula.braun@...ibm.com>
Subject: Re: [PATCH net-next 2/3] qeth: Convert use of __constant_htons to htons

On Thu, Aug 20, 2015 at 11:28 PM, David Miller <davem@...emloft.net> wrote:
> From: Ursula Braun <ubraun@...ux.vnet.ibm.com>
> Date: Thu, 20 Aug 2015 15:53:42 +0200
>
>> qeth is an s390-driver, and s390 is a big-endian architecture. Thus
>> arguments valid for little-endian do not apply to qeth-code.
>
> You can not throw out generally good tree-wide conventions just because
> it happens to work on your platform.
>
> In fact, I would be really thrilled if some of this code could be compiled
> on other platforms via COMPILE_TEST or similar, especially the socket code
> and drivers.

I have test-compiled this patch on little-endian architecture. I used
this script for cross compilation:
https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross

And it worked fine for me.

-- 
Vaishali
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html