netdev - Re: [PATCH 2/2] smsc911x: Remove dev==NULL check.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150820.143839.1401698002224846672.davem@davemloft.net>
Date:	Thu, 20 Aug 2015 14:38:39 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jeremy.linton@....com
Cc:	netdev@...r.kernel.org, gregkh@...uxfoundation.org,
	steve.glendinning@...well.net, linux@...ck-us.net
Subject: Re: [PATCH 2/2] smsc911x: Remove dev==NULL check.

From: Jeremy Linton <jeremy.linton@....com>
Date: Wed, 19 Aug 2015 11:46:43 -0500

> The dev==NULL check in smsc911x_probe_config is useless
> and isn't providing any additional protection. If a fwnode
> doesn't exist then an appropriate error should be returned
> by device_get_phy_mode() covering the original case
> of a missing of/fwnode.
> 
> Signed-off-by: Jeremy Linton <jeremy.linton@....com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html