netdev - RE: [PATCH v1 1/6] net: phy: broadcom: add bcm54220 phy ID

Open Source and information security mailing list archives

Date:	Thu, 20 Aug 2015 01:16:40 +0000
From:	Duan Andy <fugang.duan@...escale.com>
To:	Florian Fainelli <f.fainelli@...il.com>
CC:	"shawnguo@...nel.org" <shawnguo@...nel.org>,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH v1 1/6] net: phy: broadcom: add bcm54220 phy ID

From: Florian Fainelli <f.fainelli@...il.com> Sent: Thursday, August 20, 2015 5:29 AM
> To: Duan Fugang-B38611
> Cc: shawnguo@...nel.org; David Miller; netdev; linux-arm-
> kernel@...ts.infradead.org
> Subject: Re: [PATCH v1 1/6] net: phy: broadcom: add bcm54220 phy ID
> 
> 2015-08-18 22:33 GMT-07:00 Fugang Duan <b38611@...escale.com>:
> > Add bcm54220 phy ID entry.
> 
> This change itself is fine, but looking at the rest of your changes, we
> are not adding an entry for this PHY in drivers/net/phy/broadcom.c, which
> means that we will bind to the Generic PHY driver, and so this looks
> sufficient, even with your fixup done in the subsequent patch.
> 

Thanks for your comment.

Yes, for the phy, the driver use generic phy driver. 
I see all Broadcom phy ID are defined in this file, we shouldn't define new phy id in other place.
When the phy is used more popular, I think the patch is very reasonable.

> >
> > Signed-off-by: Fugang Duan <B38611@...escale.com>
> > ---
> >  include/linux/brcmphy.h | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/include/linux/brcmphy.h b/include/linux/brcmphy.h index
> > 697ca77..20bed15 100644
> > --- a/include/linux/brcmphy.h
> > +++ b/include/linux/brcmphy.h
> > @@ -16,6 +16,7 @@
> >  #define PHY_ID_BCM5482                 0x0143bcb0
> >  #define PHY_ID_BCM5411                 0x00206070
> >  #define PHY_ID_BCM5421                 0x002060e0
> > +#define PHY_ID_BCM54220                        0x600d8589
> >  #define PHY_ID_BCM5464                 0x002060b0
> >  #define PHY_ID_BCM5461                 0x002060c0
> >  #define PHY_ID_BCM54616S               0x03625d10
> > --
> > 1.9.1
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@...ts.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 
> 
> 
> --
> Florian

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives