netdev - Re: [PATCH RESEND net-next] lwtunnel: Fix the sparse warnings in fib_encap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150819.173906.397363174611794943.davem@davemloft.net>
Date:	Wed, 19 Aug 2015 17:39:06 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ying.xue@...driver.com
Cc:	netdev@...r.kernel.org, jbenc@...hat.com, fengguang.wu@...el.com,
	kbuild-all@...org
Subject: Re: [PATCH RESEND net-next] lwtunnel: Fix the sparse warnings in
 fib_encap_match

From: Ying Xue <ying.xue@...driver.com>
Date: Wed, 19 Aug 2015 15:46:17 +0800

> When CONFIG_LWTUNNEL config is not enabled, the lwtstate_free() is not
> declared in lwtunnel.h at all. However, even in this case, the function
> is still referenced in fib_semantics.c so that there appears the
> following sparse warnings:
> 
> net/ipv4/fib_semantics.c:553:17: error: undefined identifier 'lwtstate_free'
>   CC      net/ipv4/fib_semantics.o
>   net/ipv4/fib_semantics.c: In function ‘fib_encap_match’:
>   net/ipv4/fib_semantics.c:553:3: error: implicit declaration of function ‘lwtstate_free’ [-Werror=implicit-function-declaration]
>   cc1: some warnings being treated as errors
>   make[1]: *** [net/ipv4/fib_semantics.o] Error 1
>   make: *** [net/ipv4/fib_semantics.o] Error 2
> 
> To eliminate the error, we define an empty function for lwtstate_free()
> in lwtunnel.h when CONFIG_LWTUNNEL is disabled.
> 
> Fixes: df383e6240ef ("lwtunnel: fix memory leak")
> Cc: Jiri Benc <jbenc@...hat.com>
> Reported-by: kbuild test robot <fengguang.wu@...el.com>
> Signed-off-by: Ying Xue <ying.xue@...driver.com>
> Acked-by: Jiri Benc <jbenc@...hat.com>

Applied, thanks.