lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 21 Aug 2015 23:48:10 +0000 From: Duan Andy <fugang.duan@...escale.com> To: Florian Fainelli <f.fainelli@...il.com>, David Miller <davem@...emloft.net> CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "shawnguo@...nel.org" <shawnguo@...nel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org> Subject: RE: [PATCH v1 0/6] Add fec1 and fec2 support for i.MX7d sdb board From: Florian Fainelli <f.fainelli@...il.com> > Sent: Friday, August 21, 2015 5:14 AM > To: David Miller; Duan Fugang-B38611 > Cc: netdev@...r.kernel.org; shawnguo@...nel.org; linux-arm- > kernel@...ts.infradead.org > Subject: Re: [PATCH v1 0/6] Add fec1 and fec2 support for i.MX7d sdb > board > > On 20/08/15 14:05, David Miller wrote: > > From: Fugang Duan <b38611@...escale.com> > > Date: Wed, 19 Aug 2015 13:33:58 +0800 > > > >> The patch series is to add fec support for i.MX7d sdb board. Since > >> i.MX7d fec ip is the same as i.MX6SX, so there have no change for > driver itself. > >> > >> Patch#1: add bcm54220 PHY ID entry into brcmphy.h file. > > > > This is completely, and utterly, pointless. > > > > The only reason a PHY ID should be defined in brcmphy.h is so that it > > can be used in the broadcom.c PHY driver or similar. > > > > If there is no user in the tree, there is no reason to add it to the > > header file. > > There is a valid reason for which you may have a PHY id, which is > defining a PHY fixup in your platform code like Andy is doing, however, > this should not be used in conjunction with the Generic PHY driver, > because this driver has absolutely no clue about your PHY fixup, and this > could create at best inconsistencies in how the fixup is managed later on. > > At the very least, I would like to see a change to > drivers/net/phy/broadcom.c which identifies this PHY id, and eventually > just invokes the genphy_* functions where relevant. > -- > Florian I will try to add the phy support in Broadcom phy driver. Thanks for your comments. Regards, Andy
Powered by blists - more mailing lists