netdev - Re: [PATCH v3 01/10] ss: rooted out ss type declarations for output formatters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150823100758.74a626d4@urahara>
Date:	Sun, 23 Aug 2015 10:07:58 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Matthias Tafelmeier <matthias.tafelmeier@....net>
Cc:	netdev@...r.kernel.org, hagen@...u.net, shemminger@...l.org,
	fw@...len.de, edumazet@...gle.com, daniel@...earbox.net
Subject: Re: [PATCH v3 01/10] ss: rooted out ss type declarations for output
 formatters

On Thu, 20 Aug 2015 22:40:12 +0200
Matthias Tafelmeier <matthias.tafelmeier@....net> wrote:

> The prospected output formatters and ss do share type declarations like
> slabstat or tcpstat so that the decision has been made to centralize
> those declarations in ss_types.h.  Potential future declarations shall
> be placed there. The latter should help amend the extent of ss.c as
> well.
> 
> Signed-off-by: Matthias Tafelmeier <matthias.tafelmeier@....net>
> Suggested-by: Hagen Paul Pfeifer <hagen@...u.net>

I looked at this series, and was going to merge it but the code to do
json formatting gets really ugly. Please redo it with the json_writer
code I just added.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html