netdev - Re: [net-next PATCH v2 3/3] net: sched: fall back to noqueue when removing root qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150823204442.2e032436@redhat.com>
Date:	Sun, 23 Aug 2015 20:44:42 +0200
From:	Jesper Dangaard Brouer <brouer@...hat.com>
To:	Phil Sutter <phil@....cc>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	eric.dumazet@...il.com, brouer@...hat.com
Subject: Re: [net-next PATCH v2 3/3] net: sched: fall back to noqueue when
 removing root qdisc

On Sat, 22 Aug 2015 02:20:56 +0200
Phil Sutter <phil@....cc> wrote:

> When removing the root qdisc, the interface should fall back to noqueue
> as the 'real' minimal qdisc instead of the default one. 

I worry this behavior could break existing scripts.

I prefer the idea of allowing tc command to assign noqueue (to any
device).  This makes the action explicit for the user, instead of being
a side-effect of removing a qdisc. (and does not break backward compat)

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Sr. Network Kernel Developer at Red Hat
  Author of http://www.iptv-analyzer.org
  LinkedIn: http://www.linkedin.com/in/brouer
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html