| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sun, 23 Aug 2015 11:58:50 -0700 From: Florian Fainelli <f.fainelli@...il.com> To: Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net> CC: netdev <netdev@...r.kernel.org> Subject: Re: [PATCH net-next 0/9] DSA port configuration and status Le 08/23/15 02:46, Andrew Lunn a écrit : > This patchset allows various switch port settings to be configured and > port status to be sampled. Some of these patches have been posted > before. > > The first three patches provide infrastructure for configuring a > switch ports link speed and duplex from a fixed_link phy. > > Patch four then uses this infrastructure to allow the CPU and DSA > ports of a switch to be configured using a fixed-link property in the > device tree. Your changes look very clean and neat! Since we keep seeing changes around the fixed PHY driver, I am starting to wonder whether we need something more lightweight than a full fledged fixed PHY to retrieve link parameters and manage them outside of the PHY library. One of the promises of the PHY library is that you will get a number of things for free, whether you deal with a real PHY device or a fixed PHY one: ethtool reporting, adjust_link to configure the Ethernet MAC with detected/hardcoded link settings, automatic carrier settings etc... Which would have to be repeated in individual drivers utilizing a more lightweight fixed link code... > > Patches five and six allow a phy-mode property to be specified in the > device tree, and allow this to be used for configuring RGMII delays. > > Patches seven through nine allow link status, for example that of an > SFP module, to be read from a gpio. > > Please don't merge these patches until Florian Fainelli has reviewed > them. > > Andrew Lunn (8): > dsa: mv88e6xxx: Allow speed/duplex of port to be configured > phy: fixed_phy: Set supported speed in phydev > net: dsa: Allow configuration of CPU & DSA port speeds/duplex > net: dsa: Allow DSA and CPU ports to have a phy-mode property > dsa: mv88e6xxx: Set the RGMII delay based on phy interface > dsa: mv88e6xxx: Don't poll forced interfaces for state changes > phy: fixed_phy: Add gpio to determine link up/down. > phy: fixed_phy: Set phy capabilities even when link is down > > Florian Fainelli (1): > net: phy: Allow PHY devices to identify themselves as Ethernet > switches, etc. > > .../devicetree/bindings/net/fixed-link.txt | 14 ++++- > Documentation/networking/stmmac.txt | 2 +- > arch/m68k/coldfire/m5272.c | 2 +- > arch/mips/ar7/platform.c | 5 +- > arch/mips/bcm47xx/setup.c | 2 +- > drivers/net/dsa/mv88e6123_61_65.c | 1 + > drivers/net/dsa/mv88e6131.c | 1 + > drivers/net/dsa/mv88e6171.c | 1 + > drivers/net/dsa/mv88e6352.c | 1 + > drivers/net/dsa/mv88e6xxx.c | 73 ++++++++++++++++++++++ > drivers/net/dsa/mv88e6xxx.h | 4 ++ > drivers/net/ethernet/broadcom/genet/bcmmii.c | 2 +- > drivers/net/phy/fixed_phy.c | 45 ++++++++++--- > drivers/of/of_mdio.c | 13 +++- > include/linux/phy.h | 12 ++++ > include/linux/phy_fixed.h | 8 ++- > net/dsa/dsa.c | 43 +++++++++++++ > 17 files changed, 210 insertions(+), 19 deletions(-) > -- Florian -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists