netdev - Re: [PATCH] net: FIB tracepoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150823.154035.2177267760911368368.davem@davemloft.net>
Date:	Sun, 23 Aug 2015 15:40:35 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dsa@...ulusnetworks.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: FIB tracepoints

From: David Ahern <dsa@...ulusnetworks.com>
Date: Tue, 18 Aug 2015 09:49:14 -0600

> Signed-off-by: David Ahern <dsa@...ulusnetworks.com>
> ---
> I realize the sensitivity around adding tracepoints, but these have been
> invaluable developing the VRF device driver along with a return probe:
>   perf probe -a 'fib_table_lookup_ret=fib_table_lookup%return ret=%ax' 

If you want this to be considered seriously, you really have to capture
all of the parts of the flow key that can influence fib_table_lookup(),
not just src/dst/oif/iif.

Without the flags, for example, you can't even tell if it's a VRF
lookup our not.  And you'll need, at a minimum, the TOS and scope
as well.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html