netdev - Re: [PATCH v2] net: Fix RCU splat in af

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1440451686.8932.4.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Mon, 24 Aug 2015 14:28:06 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Ahern <dsa@...ulusnetworks.com>
Cc:	netdev@...r.kernel.org, steffen.klassert@...unet.com
Subject: Re: [PATCH v2] net: Fix RCU splat in af_key

On Mon, 2015-08-24 at 15:17 -0600, David Ahern wrote:
> Hit the following splat testing VRF change for ipsec:

> 
> In pfkey_sendmsg the net mutex is taken and then pfkey_broadcast takes
> the RCU lock.
> 
> Since pfkey_broadcast takes the RCU lock the allocation argument is
> pointless since GFP_ATOMIC must be used between the rcu_read_{,un}lock.
> The one call outside of rcu can be done with GFP_KERNEL.
> 
> Fixes: 7f6b9dbd5afbd ("af_key: locking change")
> Signed-off-by: David Ahern <dsa@...ulusnetworks.com>
> ---
> v2
> - removed allocation arg and hardcoded to GFP_ATOMIC during rcu locking

Acked-by: Eric Dumazet <edumazet@...gle.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html