netdev - Re: [PATCH net] net: bcmgenet: Avoid sleeping in bcmgenet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150823.225958.949245344089566556.davem@davemloft.net>
Date:	Sun, 23 Aug 2015 22:59:58 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	f.fainelli@...il.com
Cc:	netdev@...r.kernel.org, pgynther@...gle.com, jaedon.shin@...il.com
Subject: Re: [PATCH net] net: bcmgenet: Avoid sleeping in bcmgenet_timeout

From: Florian Fainelli <f.fainelli@...il.com>
Date: Thu, 20 Aug 2015 18:04:22 -0700

> bcmgenet_timeout() executes in atomic context, yet we will invoke
> napi_disable() which does sleep. Looking back at the changes, disabling
> TX napi and re-enabling it is completely useless, since we reclaim all
> TX buffers and re-enable interrupts, and wake up the TX queues.
> 
> Fixes: 13ea657806cf ("net: bcmgenet: improve TX timeout")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Applied, thanks Florian.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html