netdev - Re: [PATCH net] sctp: asconf's process should verify address parameter is in the beginning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55DB0A4F.8090004@cogentembedded.com>
Date:	Mon, 24 Aug 2015 15:13:03 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Xin Long <lucien.xin@...il.com>,
	network dev <netdev@...r.kernel.org>
Cc:	mleitner@...hat.com, davem@...emloft.net
Subject: Re: [PATCH net] sctp: asconf's process should verify address
 parameter is in the beginning

Hello.

On 8/24/2015 1:07 PM, Xin Long wrote:

> in sctp_process_asconf(), we get address parameter from the beginning of the
> addip params. but we never check if it's really there. if the addr param is not
> there, it still can pass sctp_verify_asconf(), then to be handled by
> sctp_process_asconf(), it will not be safe.
>
> so add a code in sctp_verify_asconf() to check the address parameter is in the
> beginning, or return false to send abort.
>
> Signed-off-by: Xin Long <lucien.xin@...il.com>
> ---
>   net/sctp/sm_make_chunk.c | 8 ++++++++
>   1 file changed, 8 insertions(+)

> diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c
> index 0ee5ca7..a2a72d5 100644
> --- a/net/sctp/sm_make_chunk.c
> +++ b/net/sctp/sm_make_chunk.c
> @@ -3122,6 +3122,14 @@ bool sctp_verify_asconf(const struct sctp_association *asoc,
>   	union sctp_params param;
>   	bool addr_param_seen = false;
>
> +	if(addr_param_needed){

    Space needed after *if*. Please run your patches thru 
scripts/checkpatch.pl before posting.

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html