netdev - Re: [PATCH, net-next] r8169: On RTL 8101 series bit SYSErr is reserved.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 24 Aug 2015 11:38:18 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	corcodel.marian@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH, net-next] r8169: On RTL 8101 series bit SYSErr is
 reserved.

From: Corcodel Marian <corcodel.marian@...il.com>
Date: Mon, 24 Aug 2015 21:12:53 +0300

> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 5693e65..32d2072 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -8256,6 +8256,14 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>  	RTL_W8(Config1, RTL_R8(Config1) | PMEnable);
>  	RTL_W8(Config5, RTL_R8(Config5) & (BWF | MWF | UWF | LanWake | PMEStatus));*/
>  	switch (tp->mac_version) {
> +	case RTL_GIGA_MAC_VER_07:
> +	case RTL_GIGA_MAC_VER_08:
> +	case RTL_GIGA_MAC_VER_09:
> +	case RTL_GIGA_MAC_VER_10:
> +	case RTL_GIGA_MAC_VER_13:
> +	case RTL_GIGA_MAC_VER_16:
> +		pci_write_config_word(pdev, PCI_COMMAND, ~PCI_COMMAND_SERR); 

You're writing all sorts of bits you definitely don't want to set here.

Furthermore, there is no need to clear a bit that shouldn't be set
in the first place.

Your patches are really full of major errors, and unsuitable for
upstream.

Yes, all of them.

So please stop posting your r8169 changes here, because if you don't
care if your patches get included or not, then you should not be
posting them here.  This isn't a place to just dump ramdom patches,
sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html