netdev - Re: [PATCH net-next 09/13] vxlan: provide access function for vxlan socket address family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150825181243.26f9ff99@griffin>
Date:	Tue, 25 Aug 2015 18:12:43 +0200
From:	Jiri Benc <jbenc@...hat.com>
To:	"Rustad, Mark D" <mark.d.rustad@...el.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Thomas Graf <tgraf@...g.ch>
Subject: Re: [PATCH net-next 09/13] vxlan: provide access function for vxlan
 socket address family

On Tue, 25 Aug 2015 00:34:18 +0000, Rustad, Mark D wrote:
> > --- a/include/net/vxlan.h
> > +++ b/include/net/vxlan.h
> > @@ -241,3 +241,8 @@ static inline void vxlan_get_rx_port(struct net_device *netdev)
> > }
> > #endif
> > #endif
> > +
> > +static inline unsigned short vxlan_get_sk_family(struct vxlan_sock *vs)
> > +{
> > +	return vs->sock->sk->sk_family;
> > +}
> 
> This causes build problems because vxlan_get_sk_family is not inside the #endif
> protecting the file for multiple inclusion. Please put vxlan_get_sk_family
> inside the last #endif.

That's what happens when you rebase the whole set several times :-/
Thanks for the report. I'll send a patch.

 Jiri

-- 
Jiri Benc
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html