netdev - Re: [PATCH v3 net-next 3/8] tunnel: introduce udp_tun_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 Aug 2015 19:46:39 +0200
From:	Thomas Graf <tgraf@...g.ch>
To:	Pravin B Shelar <pshelar@...ira.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v3 net-next 3/8] tunnel: introduce udp_tun_rx_dst()

On 08/24/15 at 10:43am, Pravin B Shelar wrote:
> Introduce function udp_tun_rx_dst() to initialize tunnel dst on
> receive path.
> 
> Signed-off-by: Pravin B Shelar <pshelar@...ira.com>
> +	if (family == AF_INET)
> +		tun_dst = ip_tun_rx_dst(skb, flags, tunnel_id, md_size);
> +	else
> +		tun_dst = ipv6_tun_rx_dst(skb, flags, tunnel_id, md_size);

Might look a bit cleaner if you add the address specific code inside
ip_tun_rx_dst() directly. I'm fine either way though.

Acked-by: Thomas Graf <tgraf@...g.ch>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html