netdev - Re: [PATCH, net-next] r8169:Correct value on r810x_phy_power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150826.104129.894959895104249315.davem@davemloft.net>
Date:	Wed, 26 Aug 2015 10:41:29 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	corcodel.marian@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH, net-next] r8169:Correct value on r810x_phy_power_up
 function

From: Corcodel Marian <corcodel.marian@...il.com>
Date: Wed, 26 Aug 2015 15:16:10 +0300

> Correct value on r810x_phy_power_up function normal clean 
>  bit BMCR_PDOWN
> 
> Signed-off-by: Corcodel Marian <corcodel.marian@...il.com>
> 
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index d6d39df..91cf3a6 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -4669,7 +4669,7 @@ static void r810x_phy_power_down(struct rtl8169_private *tp)
>  static void r810x_phy_power_up(struct rtl8169_private *tp)
>  {
>  	rtl_writephy(tp, 0x1f, 0x0000);
> -	rtl_writephy(tp, MII_BMCR, BMCR_ANENABLE);
> +	rtl_writephy(tp, MII_BMCR, ~BMCR_PDOWN);

This DOES NOT only clear BMCR_PDOWN, it sets every other bit in the
register as well.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html