netdev - Re: [v2] net: phy: fixed: propagate fixed link values to struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55DE09E5.1080008@gmail.com>
Date:	Wed, 26 Aug 2015 11:48:05 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	madalin.bucur@...escale.com, stsp@...t.ru
CC:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Igal.Liberman@...escale.com, andrew@...n.ch
Subject: Re: [v2] net: phy: fixed: propagate fixed link values to struct

On 26/08/15 07:58, Madalin Bucur wrote:
> The fixed link values parsed from the device tree are stored in
> the struct fixed_phy member status. The struct phy_device members
> speed, duplex were not updated.

Arguably you need to start the PHY state machine for this to work
properly, but this looks fine to me.

> 
> Signed-off-by: Madalin Bucur <madalin.bucur@...escale.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

> ---
> v2: always setting phy->link, thanks Stas
> 
>  drivers/net/phy/fixed_phy.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/net/phy/fixed_phy.c b/drivers/net/phy/fixed_phy.c
> index 479b93f..99d9bc1 100644
> --- a/drivers/net/phy/fixed_phy.c
> +++ b/drivers/net/phy/fixed_phy.c
> @@ -292,6 +292,15 @@ struct phy_device *fixed_phy_register(unsigned int irq,
>  		return ERR_PTR(-EINVAL);
>  	}
>  
> +	/* propagate the fixed link values to struct phy_device */
> +	phy->link = status->link;
> +	if (status->link) {
> +		phy->speed = status->speed;
> +		phy->duplex = status->duplex;
> +		phy->pause = status->pause;
> +		phy->asym_pause = status->asym_pause;
> +	}
> +
>  	of_node_get(np);
>  	phy->dev.of_node = np;
>  
> 


-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html