netdev - Re: [PATCH net-next] net: sched: consolidate tc_classify{,

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55DE3776.2060700@iogearbox.net>
Date:	Thu, 27 Aug 2015 00:02:30 +0200
From:	Daniel Borkmann <daniel@...earbox.net>
To:	Alexei Starovoitov <ast@...mgrid.com>, davem@...emloft.net
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: sched: consolidate tc_classify{,_compat}

On 08/26/2015 11:54 PM, Alexei Starovoitov wrote:
> On 8/26/15 2:00 PM, Daniel Borkmann wrote:
...
>> +reset:
>> +    if (unlikely(limit++ >= MAX_REC_LOOP)) {
>> +        net_notice_ratelimited("%s: reclassify loop, rule prio %u, "
>> +                       "protocol %02x\n", tp->q->ops->id,
>> +                       tp->prio & 0xffff, ntohs(tp->protocol));
>
> why drop 'packet' and add two extra ',' in the message ?
> Not a big deal, just why bother?

No deep underlying reason, thought it would make it slightly
more readable.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html