netdev - Re: [PATCH RFC 5/5] net: dsa: bcm_sf2: Allow disabling tagging protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150825.170907.650915573418643373.davem@davemloft.net>
Date:	Tue, 25 Aug 2015 17:09:07 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	f.fainelli@...il.com
Cc:	netdev@...r.kernel.org, andrew@...n.ch, linux@...ck-us.net,
	jiri@...nulli.us, sfeldma@...il.com
Subject: Re: [PATCH RFC 5/5] net: dsa: bcm_sf2: Allow disabling tagging
 protocol

From: Florian Fainelli <f.fainelli@...il.com>
Date: Tue, 25 Aug 2015 15:50:15 -0700

>  	/* Enable Broadcom tags for IMP port */
>  	reg = core_readl(priv, CORE_BRCM_HDR_CTRL);
> -	reg |= val;
> +	if (!tagging_disabled)

Just a pet-peeve of mine, I hate conditions that read as double
negatives, like this one does.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html