netdev - Re: [patch net-next v2 2/3] mlxsw: adjust transmit fail log message level in __mlxsw_emad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1440698180.11525.98.camel@perches.com>
Date:	Thu, 27 Aug 2015 10:56:20 -0700
From:	Joe Perches <joe@...ches.com>
To:	Jiri Pirko <jiri@...nulli.us>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, idosch@...lanox.com,
	eladr@...lanox.com, ogerlitz@...lanox.com,
	Jiri Pirko <jiri@...lanox.com>
Subject: Re: [patch net-next v2 2/3] mlxsw: adjust transmit fail log message
 level in __mlxsw_emad_transmit

On Thu, 2015-08-27 at 17:59 +0200, Jiri Pirko wrote:
> When transmit fails, it is an error, not a warning.
[]
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/core.c b/drivers/net/ethernet/mellanox/mlxsw/core.c
[]
> @@ -376,8 +376,8 @@ static int __mlxsw_emad_transmit(struct mlxsw_core *mlxsw_core,
>  
>  	err = mlxsw_core_skb_transmit(mlxsw_core->driver_priv, skb, tx_info);
>  	if (err) {
> -		dev_warn(mlxsw_core->bus_info->dev, "Failed to transmit EMAD (tid=%llx)\n",
> -			 mlxsw_core->emad.tid);
> +		dev_err(mlxsw_core->bus_info->dev, "Failed to transmit EMAD (tid=%llx)\n",
> +			mlxsw_core->emad.tid);

dev_err_ratelimited?


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html