netdev - Re: [PATCH -next v3 2/2] smsc911x: Ignore error return from device_get_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150827.142506.1827996120270363660.davem@davemloft.net>
Date:	Thu, 27 Aug 2015 14:25:06 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	linux@...ck-us.net
Cc:	gregkh@...uxfoundation.org, steve.glendinning@...well.net,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	rafael.j.wysocki@...el.com, jeremy.linton@....com, tony@...mide.com
Subject: Re: [PATCH -next v3 2/2] smsc911x: Ignore error return from
 device_get_phy_mode()

From: Guenter Roeck <linux@...ck-us.net>
Date: Wed, 26 Aug 2015 20:27:05 -0700

> Commit 62ee783bf1f8 ("smsc911x: Fix crash seen if neither ACPI nor OF is
> configured or used") introduces an error check for the return value from
> device_get_phy_mode() and bails out if there is an error. Unfortunately,
> there are configurations where no phy is configured. Those configurations
> now fail.
> 
> To fix the problem, accept error returns from device_get_phy_mode(),
> and use the return value from device_property_read_u32() to determine
> if there is a suitable firmware interface to read the configuration.
> 
> Fixes: 62ee783bf1f8 ("smsc911x: Fix crash seen if neither ACPI nor OF is configured or used")
> Tested-by: Tony Lindgren <tony@...mide.com>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html