netdev - Re: [PATCH v4 net-next 7/8] geneve: Consolidate Geneve functionality in single module.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEP_g=9mn5_+JZKSh06m9qCNGjL83uSja39J85gjS4GCyM33Vw@mail.gmail.com>
Date:	Wed, 26 Aug 2015 21:06:48 -0700
From:	Jesse Gross <jesse@...ira.com>
To:	Pravin Shelar <pshelar@...ira.com>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v4 net-next 7/8] geneve: Consolidate Geneve functionality
 in single module.

On Wed, Aug 26, 2015 at 8:57 PM, Pravin Shelar <pshelar@...ira.com> wrote:
> On Wed, Aug 26, 2015 at 8:08 PM, Jesse Gross <jesse@...ira.com> wrote:
>> On Wed, Aug 26, 2015 at 2:54 PM, Pravin B Shelar <pshelar@...ira.com> wrote:
>>> @@ -293,15 +615,13 @@ static netdev_tx_t geneve_xmit(struct sk_buff *skb, struct net_device *dev)
>> [...]
>>> +               err = geneve_build_skb(rt, skb, key->tun_flags, vni,
>>> +                                      info->options_len, opts, udp_csum);
>>> +               if (unlikely(err))
>>> +                       goto err;
>> [...]
>>>  tx_error:
>>> -       dev->stats.tx_errors++;
>>>         dev_kfree_skb(skb);
>>> +err:
>>> +       dev->stats.tx_errors++;
>>>         return NETDEV_TX_OK;
>>>  }
>>
>> I'm not sure that it makes sense to break out these error conditions -
>> geneve_build_skb() doesn't free the skb, so it looks like there is a
>> leak on failure.
>
> It does frees skb. Which case are you looking at?

Never mind, you're right.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html