netdev - Re: [PATCH net-next v2] net: sched: consolidate tc_classify{,

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150827.161145.2273321237879729255.davem@davemloft.net>
Date:	Thu, 27 Aug 2015 16:11:45 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	daniel@...earbox.net
Cc:	ast@...mgrid.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: sched: consolidate
 tc_classify{,_compat}

From: Daniel Borkmann <daniel@...earbox.net>
Date: Thu, 27 Aug 2015 10:11:37 +0200

> For classifiers getting invoked via tc_classify(), we always need an
> extra function call into tc_classify_compat(), as both are being
> exported as symbols and tc_classify() itself doesn't do much except
> handling of reclassifications when tp->classify() returned with
> TC_ACT_RECLASSIFY.
> 
> CBQ and ATM are the only qdiscs that directly call into tc_classify_compat(),
> all others use tc_classify(). When tc actions are being configured
> out in the kernel, tc_classify() effectively does nothing besides
> delegating.
> 
> We could spare this layer and consolidate both functions. Artificial
> pktgen micro benchmark on single CPU constantly pushing skbs directly
> into the netif_receive_skb() path with a dummy classifier on ingress
> qdisc attached, improves slightly from 22.3Mpps to 23.1Mpps.
> 
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
> Acked-by: Alexei Starovoitov <ast@...mgrid.com>
> ---
>  v1 -> v2:
>   - Addressed minor style nits found by Alexei.

Sorry, I applied v1 before seeing this :-/

If you could post a relative patch fixing the style issues, I'd
appreciate it.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html