netdev - Re: [PATCH net-next] bridge: fdb: rearrange net_bridge_fdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150827.163909.1905886152046450354.davem@davemloft.net>
Date:	Thu, 27 Aug 2015 16:39:09 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	razor@...ckwall.org
Cc:	netdev@...r.kernel.org, stephen@...workplumber.org,
	bridge@...ts.linux-foundation.org, nikolay@...ulusnetworks.com
Subject: Re: [PATCH net-next] bridge: fdb: rearrange net_bridge_fdb_entry

From: Nikolay Aleksandrov <razor@...ckwall.org>
Date: Thu, 27 Aug 2015 14:19:20 -0700

> From: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> 
> While looking into fixing the local entries scalability issue I noticed
> that the structure is badly arranged because vlan_id would fall in a
> second cache line while keeping rcu which is used only when deleting
> in the first, so re-arrange the structure and push rcu to the end so we
> can get 16 bytes which can be used for other fields (by pushing rcu
> fully in the second 64 byte chunk). With this change all the core
> necessary information when doing fdb lookups will be available in a
> single cache line.
 ...
> Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>

This looks fine, applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html