netdev - Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpUwHSDnE=C8OMGgUOCwSZo2Cgi=0Dh6GRvmX8BEEGN_Uw@mail.gmail.com>
Date:	Wed, 26 Aug 2015 17:14:54 -0700
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to
 inappropriate ones

On Wed, Aug 26, 2015 at 5:08 PM, Stephen Hemminger
<stephen@...workplumber.org> wrote:
> On Wed, 26 Aug 2015 15:41:26 -0700
> Cong Wang <xiyou.wangcong@...il.com> wrote:
>
>> Currently there is no check for if a qdisc is appropriate
>> to be used as the default qdisc. This causes we get no
>> error even we set the default qdisc to an inappropriate one
>> but an error will be shown up later. This is not good.
>>
>> Also, for qdisc's like HTB, kernel will just crash when
>> we use it as default qdisc, because some data structures are
>> not even initialized yet before checking opt == NULL, the cleanup
>> doing ->reset() or ->destroy() on them will just crash.
>
> Why not fix the buggy one's instead?

They are not exactly buggy, since they are fine in other ->init() calling
cases.

As in the first paragraph you quoted from me, it is more like
a usability issue, for example ingress qdisc can be set as default
without any error at any time.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html