netdev - Re: [PATCH net-next] r8169: Add software counter for multicast packages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150828.132305.59133940834058930.davem@davemloft.net>
Date:	Fri, 28 Aug 2015 13:23:05 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	vinschen@...hat.com
Cc:	netdev@...r.kernel.org, romieu@...zoreil.com, nic_swsd@...ltek.com,
	ivecera@...hat.com
Subject: Re: [PATCH net-next] r8169: Add software counter for multicast
 packages

From: Corinna Vinschen <vinschen@...hat.com>
Date: Thu, 27 Aug 2015 17:11:48 +0200

> The multicast hardware counter on 8168/8111 chips is only 32 bit while the
> statistics in struct rtnl_link_stats64 are 64 bit.  Given that statistics
> are requested on an irregular basis, an overflow of the hardware counter
> can go unnoticed.  To count even very large numbers of multicast packets
> reliably, add a software counter and remove previously applied code to
> fill the multicast field requested by @rtl8169_get_stats64 with the values
> read from the rx_multicast hardware counter.
> 
> Signed-off-by: Corinna Vinschen <vinschen@...hat.com>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html