netdev - Re: [PATCH net v3] sctp: donot reset the overall_error_count in SHUTDOWN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150827.171206.1343630245407773111.davem@davemloft.net>
Date:	Thu, 27 Aug 2015 17:12:06 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	lucien.xin@...il.com
Cc:	netdev@...r.kernel.org, mleitner@...hat.com, vyasevic@...hat.com
Subject: Re: [PATCH net v3] sctp: donot reset the overall_error_count in
 SHUTDOWN_RECEIVE state

From: Xin Long <lucien.xin@...il.com>
Date: Thu, 27 Aug 2015 04:52:20 +0800

> Commit f8d960524328 ("sctp: Enforce retransmission limit during shutdown")
> fixed a problem with excessive retransmissions in the SHUTDOWN_PENDING by not
> resetting the association overall_error_count.  This allowed the association
> to better enforce assoc.max_retrans limit.
> 
> However, the same issue still exists when the association is in SHUTDOWN_RECEIVED
> state.  In this state, HB-ACKs will continue to reset the overall_error_count
> for the association would extend the lifetime of association unnecessarily.
> 
> This patch solves this by resetting the overall_error_count whenever the current
> state is small then SCTP_STATE_SHUTDOWN_PENDING.  As a small side-effect, we
> end up also handling SCTP_STATE_SHUTDOWN_ACK_SENT and SCTP_STATE_SHUTDOWN_SENT
> states, but they are not really impacted because we disable Heartbeats in those
> states.
> 
> Fixes: Commit f8d960524328 ("sctp: Enforce retransmission limit during shutdown")
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html